Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helia.js.org #8473

Merged
merged 3 commits into from
Sep 11, 2023
Merged

helia.js.org #8473

merged 3 commits into from
Sep 11, 2023

Conversation

whizzzkid
Copy link
Contributor

@whizzzkid whizzzkid commented Sep 2, 2023

Signed-off-by: Nishant Arora <[email protected]>
@MattIPv4 MattIPv4 changed the title feat: ➕ Adding helia.js.org helia.js.org Sep 2, 2023
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 2, 2023
@indus
Copy link
Member

indus commented Sep 5, 2023

@whizzzkid any updates?

@whizzzkid
Copy link
Contributor Author

Apologies @Justman10000 and @indus, waiting for ipfs/helia#252 to go through.

@MattIPv4
Copy link
Member

MattIPv4 commented Sep 5, 2023

I do not quite understand! What does this have to do with js.org?

If you looked at the PR linked, it is the PR to add the required CNAME file to their project so that their GitHub Pages site will accept traffic from the js.org subdomain being requested.

@whizzzkid
Copy link
Contributor Author

Sorry about the confusion @MattIPv4 @Justman10000, we now have helia.io servicing our needs, but would also like helia.js.org to redirect to helia.io.

I created: https://github.com/ipfs-examples/helia which has the domain set to helia.js.org. Does this look good?

@indus
Copy link
Member

indus commented Sep 11, 2023

@whizzzkid we don't support those redirects. The minimum is something like: https://vue.js.org/, https://next.js.org/ (without automatic redirect)

@whizzzkid
Copy link
Contributor Author

Thanks @indus, updated:

helia-sm helia-lg

@indus indus added add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 11, 2023
@indus
Copy link
Member

indus commented Sep 11, 2023

Welcome https://helia.js.org

@indus indus merged commit eac0603 into js-org:master Sep 11, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain organisation This PR/issue is regarding a target on a GitHub organisation project This PR has a target of a project on an organisation or user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants