Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-dnd-cn.js.org #8476

Merged
merged 2 commits into from
Sep 3, 2023
Merged

react-dnd-cn.js.org #8476

merged 2 commits into from
Sep 3, 2023

Conversation

CuiBenyong
Copy link
Contributor

@MattIPv4 MattIPv4 changed the title feat: add react-dnd-doc.js.org react-dnd-doc.js.org Sep 2, 2023
@MattIPv4
Copy link
Member

MattIPv4 commented Sep 2, 2023

👋 Have you considered working with the React DnD team to directly integrate your translation with their documentation, rather than claiming a js.org subdomain specifically for your Chinese documentation of the existing project?

If you do go down the route of having a js.org subdomain, I would recommend requesting something like react-dnd-cn.js.org or similar to make it clear this is a Chinese translation of the documentation.

@MattIPv4 MattIPv4 added the awaiting response This PR is waiting for a response from the requester label Sep 2, 2023
@CuiBenyong
Copy link
Contributor Author

👋 Have you considered working with the React DnD team to directly integrate your translation with their documentation, rather than claiming a js.org subdomain specifically for your Chinese documentation of the existing project?

If you do go down the route of having a js.org subdomain, I would recommend requesting something like react-dnd-cn.js.org or similar to make it clear this is a Chinese translation of the documentation.

Hi, I have no idea to work with the React DnD team, just translate the documentation for Chinese developers, and the CNAME has been change to react-dnd-cn.js.org. Thank you!

@indus indus added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting CNAME This PR is waiting for the target to add a CNAME file and removed awaiting response This PR is waiting for a response from the requester labels Sep 2, 2023
@indus indus changed the title react-dnd-doc.js.org react-dnd-cn.js.org Sep 2, 2023
@indus
Copy link
Member

indus commented Sep 2, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line react-dnd-cn.js.org to make it work.
I'll merge after we have "contact". Please keep this PR open.

@CuiBenyong
Copy link
Contributor Author

I've already added your requested subdomain to JS.ORGs zonefile. But you have to (re-)add a file named CNAME to your branch with the single line react-dnd-cn.js.org to make it work. I'll merge after we have "contact". Please keep this PR open.

The CNAME file has been added and the domain react-dnd-cn.js.org is now working, thanks!

@MattIPv4
Copy link
Member

MattIPv4 commented Sep 2, 2023

No, this should be left open so it can be merged

@MattIPv4
Copy link
Member

MattIPv4 commented Sep 3, 2023

When @indus is around :)

@indus indus removed the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 3, 2023
@indus
Copy link
Member

indus commented Sep 3, 2023

Welcome https://react-dnd-cn.js.org

@indus indus merged commit 6ee86a0 into js-org:master Sep 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants