Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chronosis.js.org #8504

Merged
merged 1 commit into from
Sep 14, 2023
Merged

chronosis.js.org #8504

merged 1 commit into from
Sep 14, 2023

Conversation

jack-weilage
Copy link
Contributor

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

❌ Before we can accept your domain request, you need to configure your GitHub Pages site to use the requested js.org subdomain. Head to your repository settings, locate the Pages settings (under Code and Automation), and enter the js.org subdomain in the custom domain field. 📝

@MattIPv4 MattIPv4 added the awaiting CNAME This PR is waiting for the target to add a CNAME file label Sep 13, 2023
@jack-weilage
Copy link
Contributor Author

Should be done!

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/jack-weilage/chronosis/tree/main/docs

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account and removed awaiting CNAME This PR is waiting for the target to add a CNAME file labels Sep 13, 2023
@indus indus added the error The page requested returns an error label Sep 14, 2023
@indus
Copy link
Member

indus commented Sep 14, 2023

I've already added your requested subdomain to JS.ORGs zonefile. But I get an error when trying to open the page. In case you are using a workflow to deploy the page there may be other steps involved to get the CNAME working. FYI: #7853 (comment)

@jack-weilage
Copy link
Contributor Author

Looks like it's working now (at least for me).

@indus indus removed the error The page requested returns an error label Sep 14, 2023
@indus
Copy link
Member

indus commented Sep 14, 2023

Welcome https://chronosis.js.org

@indus indus merged commit 1584d5c into js-org:master Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants