Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

js2lua.js.org #9318

Merged
merged 2 commits into from
Oct 11, 2024
Merged

js2lua.js.org #9318

merged 2 commits into from
Oct 11, 2024

Conversation

xiangnanscu
Copy link
Contributor

@xiangnanscu xiangnanscu commented Oct 10, 2024

@xiangnanscu
Copy link
Contributor Author

this site is about translate js to lua.

Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/xiangnanscu/js2lua/blob/master/src/App.vue

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account labels Oct 10, 2024
@indus indus added the error The page requested returns an error label Oct 10, 2024
@indus
Copy link
Member

indus commented Oct 10, 2024

I've already added your requested subdomain to JS.ORGs zonefile. But it looks like your page has problems with the changed path. Please fix this to give me a chance to have a look at it.
I'll merge after we have "contact". Please keep this PR open.

@xiangnanscu
Copy link
Contributor Author

@indus Hello, seems OK now, please check.

@indus indus removed the error The page requested returns an error label Oct 11, 2024
@indus
Copy link
Member

indus commented Oct 11, 2024

Welcome https://js2lua.js.org

@indus indus merged commit 888e585 into js-org:master Oct 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants