Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modeling): expose hullPoints2 and hullPoints3 #1345

Merged
merged 4 commits into from
Jun 22, 2024
Merged

fix(modeling): expose hullPoints2 and hullPoints3 #1345

merged 4 commits into from
Jun 22, 2024

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented May 31, 2024

These changes expose hullPoints2() and hullPoints3(), which will allow users to use these functions to create custom geometries, etc.

NOTE: hullPoints3() is new, and hullGeom3() has been changed to use this function.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

@z3dev z3dev requested review from platypii and hrgdavor May 31, 2024 07:17
@z3dev z3dev changed the title fix(modeling): expose all versions of hull functions fix(modeling): expose hullPoints2 and hullPoints3 Jun 18, 2024
@z3dev
Copy link
Member Author

z3dev commented Jun 18, 2024

@platypii @hrgdavor please review. all comments welcome.

platypii
platypii previously approved these changes Jun 18, 2024
Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, seems useful

@z3dev z3dev merged commit 01ceae8 into master Jun 22, 2024
4 checks passed
@z3dev z3dev deleted the fix-hulls branch June 22, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants