Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(all): sync changes to v3 #1348

Merged
merged 9 commits into from
Jun 4, 2024
Merged

fix(all): sync changes to v3 #1348

merged 9 commits into from
Jun 4, 2024

Conversation

z3dev
Copy link
Member

@z3dev z3dev commented Jun 4, 2024

These changes bring in the latest changes from master into the V3 branch, with some changes.

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Does your submission pass tests?

Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Side note, but at some point before releasing V3, we MERGE from master into V3, and then, importantly, DO NOT SQUASH MERGE. That way when eventually V3 becomes the master branch... authors get credit for their commits (right now commits from master post v3 split will be lost).

@z3dev
Copy link
Member Author

z3dev commented Jun 4, 2024

Side note, but at some point before releasing V3, we MERGE from master into V3, and then, importantly, DO NOT SQUASH MERGE. That way when eventually V3 becomes the master branch... authors get credit for their commits (right now commits from master post v3 split will be lost).

That would be cool but I haven't seen large merges work well.

@z3dev z3dev closed this Jun 4, 2024
@z3dev z3dev reopened this Jun 4, 2024
@z3dev z3dev merged commit c263907 into V3 Jun 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants