Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scission.d.ts #1355

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Update scission.d.ts #1355

merged 3 commits into from
Aug 17, 2024

Conversation

FishOrBear
Copy link
Contributor

Fix this return result.

@FishOrBear FishOrBear closed this Jul 26, 2024
@FishOrBear FishOrBear reopened this Jul 26, 2024
platypii
platypii previously approved these changes Jul 26, 2024
Copy link
Contributor

@platypii platypii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@platypii
Copy link
Contributor

Technically scission does not support Geom2 so that first line could actually be deleted...

@z3dev
Copy link
Member

z3dev commented Jul 28, 2024

@FishOrBear technically, this is correct, however scission of geom2 is not performed, only the original geom2 objects are returned. Is that ok?

of course, if you submit the code for geom2 scission then we would be really happy.

@FishOrBear
Copy link
Contributor Author

@z3dev ok, I have updated the code

Copy link
Member

@z3dev z3dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FishOrBear looks fine. Thanks

@z3dev z3dev merged commit ad3d37d into jscad:master Aug 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants