Bugfixing of speech-to-text component

backend/src/main/java/com/talkforgeai/backend/assistant/service/AssistantSpringService.java

@@ -36,6 +36,7 @@
 import com.talkforgeai.backend.assistant.repository.AssistantRepository;
 import com.talkforgeai.backend.assistant.repository.MessageRepository;
 import com.talkforgeai.backend.assistant.repository.ThreadRepository;
+import com.talkforgeai.backend.service.UniqueIdGenerator;
 import com.talkforgeai.backend.storage.FileStorageService;
 import com.talkforgeai.backend.transformers.MessageProcessor;
 import jakarta.transaction.Transactional;

backend/src/main/java/com/talkforgeai/backend/assistant/service/UniqueIdGenerator.java → backend/src/main/java/com/talkforgeai/backend/service/UniqueIdGenerator.java

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package com.talkforgeai.backend.assistant.service;
+package com.talkforgeai.backend.service;
 
 import java.security.SecureRandom;
 import org.springframework.stereotype.Component;
@@ -45,6 +45,10 @@ public String generateImageId() {
     return generateUniqueId("img", 20);
   }
 
+  public String generateAudioId() {
+    return generateUniqueId("aud", 20);
+  }
+
   public String generateUniqueId(String prefix, int length) {
     String randomChars = generateRandomString(length);
     return prefix + "_" + randomChars;

backend/src/main/java/com/talkforgeai/backend/storage/FileStorageService.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2023 Jean Schmitz.
+ * Copyright (c) 2023-2024 Jean Schmitz.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -17,71 +17,77 @@
 package com.talkforgeai.backend.storage;
 
 import jakarta.annotation.PostConstruct;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Value;
-import org.springframework.stereotype.Service;
-
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.springframework.beans.factory.annotation.Value;
+import org.springframework.stereotype.Service;
 
 @Service
 public class FileStorageService {
 
-    public static final String TALK_FORGE_DIR = ".talkforgeai";
-    public static final Logger LOGGER = LoggerFactory.getLogger(FileStorageService.class);
+  public static final String TALK_FORGE_DIR = ".talkforgeai";
+  public static final Logger LOGGER = LoggerFactory.getLogger(FileStorageService.class);
+
+  @Value("${talkforgeai.datadir:}")
+  private String configDataDirectory;
 
-    @Value("${talkforgeai.datadir:}")
-    private String configDataDirectory;
+  private Path dataDirectory;
 
-    private Path dataDirectory;
+  public FileStorageService() {
+  }
 
-    public FileStorageService() {
+  @PostConstruct
+  private void postConstruct() {
+    if (configDataDirectory != null && !configDataDirectory.isEmpty()) {
+      this.dataDirectory = Path.of(configDataDirectory);
+
+    } else {
+      this.dataDirectory = Paths.get(System.getProperty("user.home"))
+          .resolve(TALK_FORGE_DIR)
+          .normalize();
     }
 
-    @PostConstruct
-    private void postConstruct() {
-        if (configDataDirectory != null && !configDataDirectory.isEmpty()) {
-            this.dataDirectory = Path.of(configDataDirectory);
+    LOGGER.info("Data directory set to {}", this.dataDirectory);
+  }
 
-        } else {
-            this.dataDirectory = Paths.get(System.getProperty("user.home"))
-                    .resolve(TALK_FORGE_DIR)
-                    .normalize();
-        }
+  public Path getTempDirectory() {
+    return this.dataDirectory.resolve("temp");
+  }
 
-        LOGGER.info("Data directory set to {}", this.dataDirectory);
-    }
+  public Path getDataDirectory() {
+    return this.dataDirectory;
+  }
 
-    public Path getDataDirectory() {
-        return this.dataDirectory;
-    }
+  public Path getAssistantsDirectory() {
+    return getDataDirectory().resolve("assistants");
+  }
 
-    public Path getAssistantsDirectory() {
-        return getDataDirectory().resolve("assistants");
-    }
+  public Path getThreadDirectory() {
+    return getDataDirectory().resolve("threads");
+  }
 
-    public Path getThreadDirectory() {
-        return getDataDirectory().resolve("threads");
-    }
+  public void createDataDirectories() {
+    try {
+      Path createdPath = Files.createDirectories(getDataDirectory());
+      LOGGER.info("Created data directory {}", createdPath);
 
-    public void createDataDirectories() {
-        try {
-            Path createdPath = Files.createDirectories(getDataDirectory());
-            LOGGER.info("Created data directory {}", createdPath);
+      createdPath = Files.createDirectories(getThreadDirectory());
+      LOGGER.info("Created threads directory {}", createdPath);
 
-            createdPath = Files.createDirectories(getThreadDirectory());
-            LOGGER.info("Created threads directory {}", createdPath);
+      createdPath = Files.createDirectories(getAssistantsDirectory());
+      LOGGER.info("Created assistants directory {}", createdPath);
 
-            createdPath = Files.createDirectories(getAssistantsDirectory());
-            LOGGER.info("Created assistants directory {}", createdPath);
+      createdPath = Files.createDirectories(getTempDirectory());
+      LOGGER.info("Created temp directory {}", createdPath);
 
-            LOGGER.info("Directories created successfully");
-        } catch (IOException e) {
-            LOGGER.error("Failed to create directory: " + e.getMessage());
-        }
+      LOGGER.info("Directories created successfully");
+    } catch (IOException e) {
+      LOGGER.error("Failed to create directory: " + e.getMessage());
     }
+  }
 
 }

backend/src/main/java/com/talkforgeai/backend/voice/controller/SpeechToTextController.java

@@ -41,7 +41,6 @@ public SpeechToTextController(SpeechToTextService speechToTextService,
 
   @PostMapping("/convert")
   public ResponseEntity<String> convert(@RequestParam("file") MultipartFile file) {
-    return speechToTextService.convert(file,
-        fileStorageService.getDataDirectory().resolve("uploads"));
+    return speechToTextService.convert(file, fileStorageService.getTempDirectory());
   }
 }

backend/src/main/java/com/talkforgeai/backend/voice/service/SpeechToTextService.java

@@ -16,6 +16,7 @@
 
 package com.talkforgeai.backend.voice.service;
 
+import com.talkforgeai.backend.service.UniqueIdGenerator;
 import com.talkforgeai.backend.voice.dto.TranscriptionSystem;
 import java.io.File;
 import java.io.IOException;
@@ -39,16 +40,21 @@ public class SpeechToTextService {
 
   private final UniversalTranscriptionService universalTranscriptionService;
 
-  public SpeechToTextService(UniversalTranscriptionService universalTranscriptionService) {
+  private final UniqueIdGenerator uniqueIdGenerator;
+
+  public SpeechToTextService(UniversalTranscriptionService universalTranscriptionService,
+      UniqueIdGenerator uniqueIdGenerator) {
     this.universalTranscriptionService = universalTranscriptionService;
+    this.uniqueIdGenerator = uniqueIdGenerator;
   }
 
-  public ResponseEntity<String> convert(MultipartFile file, Path uploadDirectory) {
+  public ResponseEntity<String> convert(MultipartFile file, Path tempDirectory) {
     try {
-      Files.createDirectories(uploadDirectory);
-      Path path = uploadDirectory.resolve("audio.wav");
-      file.transferTo(path);
-      String text = transscribeAudio(path.toFile());
+      Files.createDirectories(tempDirectory);
+      Path audioFile = tempDirectory.resolve(uniqueIdGenerator.generateAudioId() + ".wav");
+      file.transferTo(audioFile);
+      String text = transscribeAudio(audioFile.toFile());
+      Files.delete(audioFile);
       return ResponseEntity.ok(text);
     } catch (IOException e) {
       LOGGER.error("Failed to create directory or transfer file: {}", e.getMessage());