Add files via upload #6
Conversation
| when city is entered display results should include city name, current temp, weather description, min temp,max temp. | ||
|
|
||
| Once city is picked results should display but also change when adding an if statement to check if the weather is either above 85 degree or below 40.*/ | ||
| $(function () { |
There was a problem hiding this comment.
@Ashbk32 be careful re: indentation. It appears to be off throughout the code here in app.js. This makes it very difficult to scan and troubleshoot.
| Once city is picked results should display but also change when adding an if statement to check if the weather is either above 85 degree or below 40.*/ | ||
| $(function () { | ||
| $('#search').click(() => { | ||
| event.preventDefault() |
There was a problem hiding this comment.
@Ashbk32 this should be inside of an event handler such as a .submit() see the solution for the way it should be structured: https://github.com/jsd20191008/weather-api-app-solution/blob/master/js/main-async-await.js#L2
|
|
||
| // note added async to function | ||
|
|
||
| async function getWeather (searchTerm) { |
There was a problem hiding this comment.
@Ashbk32 looks like you're attempting to declare this function inside of the searchCity() function. You generally want to avoid that because it complicates how the functions will get called.
| // note added async to function | ||
|
|
||
| async function getWeather (searchTerm) { | ||
| try { |
There was a problem hiding this comment.
@Ashbk32 nice job here, it looks like the body of your Async / Await function is structured correctly. However, due to the comment above, getting this code to run will be difficult.
| @@ -0,0 +1,32 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
| <head> | |||
There was a problem hiding this comment.
@Ashbk32 nice updates to the html
|
@Ashbk32 Great effort here! The main issue I'd like for you to focus on is indentation. It sounds trivial but it is key to being able to troubleshoot code when things aren't working. Incorrect indentation leads to avoidable syntax errors which prevent your code from running and therefore makes it hard to fix things when they are broken. Code will always break, the key is being able to find the errors when they occur and proper indentation is a huge part of that. Take a look at the solution for more context. I suggest you pick one (I've provided solution: https://github.com/jsd20191008/weather-api-app-solution/blob/master/js/main-async-await.js#L2 |
HW 4
I had numerous issues trying to commit it and send it. I wasn't able to get it working tried multiple ways but I know I'm not confident in my coding at all. After trying to see the pattern I couldn't figure it out