Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(packagecloud): upload package to all distros and destroy older versions #138

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

radulucut
Copy link
Collaborator

@radulucut radulucut commented Oct 7, 2024

This will upload the package to all distros in deb and rpm, including any and rpm_any and destroy older versions.
PACKAGECLOUD_MAX_DISTRO_VERSIONS_TO_SUPPORT - limits the number of distro versions supported (defaults to 5)
PACKAGECLOUD_MAX_PACKAGE_VERSIONS_TO_KEEP - limits the number of binary versions to keep (defaults to 3)

@jimaek
Copy link
Member

jimaek commented Oct 7, 2024

Do you mean it will actually upload the binary per distro resulting in extra space usage or upload once and tag it with all distros? I believe they said it was possible

@radulucut
Copy link
Collaborator Author

Yes, I don't see a way to tag multiple distros to a version, unless I'm missing something.
Isn't this the same way it worked previously when upload-packagecloud was used?

@jimaek
Copy link
Member

jimaek commented Oct 8, 2024

I re-read the support ticket and indeed their solution was to use any/any, which won't work for us at all.

Could you then change the script to:

  1. Upload only the current binary to all distros, old and new. But no need to upload old versions of the binary
  2. Delete old versions and keep only last 3 Delete older versions from Packagecloud #29 to ensure we don't eat too much space as its limited

@radulucut
Copy link
Collaborator Author

radulucut commented Oct 8, 2024

To all versions?, or the latest n versions for each distro? (by version I mean distro version)

@jimaek
Copy link
Member

jimaek commented Oct 8, 2024

Hmm not sure how many there are per distro. Maybe last 5 versions? It would cover Ubuntu just fine for example

@radulucut radulucut changed the title fix: packagecloud - upload package to all distros fix: packagecloud - upload package to all distros and destroy older versions Oct 9, 2024
@MartinKolarik MartinKolarik changed the title fix: packagecloud - upload package to all distros and destroy older versions build(packagecloud): upload package to all distros and destroy older versions Oct 9, 2024
@MartinKolarik MartinKolarik merged commit cc7ea28 into jsdelivr:master Oct 9, 2024
3 checks passed
@radulucut radulucut deleted the packagecloud-fix branch October 9, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants