Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directory list workspaces #446

Merged
merged 8 commits into from
Dec 30, 2024
Merged

Directory list workspaces #446

merged 8 commits into from
Dec 30, 2024

Conversation

dmail
Copy link
Member

@dmail dmail commented Dec 30, 2024

No description provided.

Copy link

github-actions bot commented Dec 30, 2024

File size impact

Impact on file sizes when merging directory_list_workspaces into main.

dist (+0.3%)
Files new size new gzip size
dist/jsenv_core.js 715 kB (+3.6 kB / +0.5%) 157 kB (+595 B / +0.4%) ↗️
Unmodified (115) 450 kB (0 B / +0%) 124 kB (0 B / +0%) 👻
Total (116) 1.2 MB (+3.6 kB / +0.3%) 281 kB (+595 B / +0.2%) ↗️
Generated by @jsenv/file-size-impact during file size impact#12545652250 on 6f1acf7

Copy link

github-actions bot commented Dec 30, 2024


Error: Error while trying to collect info after merging directory_list_workspaces into main.

Error: Command failed: git fetch --no-tags --prune origin directory_list_workspaces
fatal: couldn't find remote ref directory_list_workspaces

    at genericNodeError (node:internal/errors:983:15)
    at wrappedFn (node:internal/errors:537:14)
    at ChildProcess.exithandler (node:child_process:421:12)
    at ChildProcess.emit (node:events:520:28)
    at maybeClose (node:internal/child_process:1105:16)
    at Socket. (node:internal/child_process:457:11)
    at Socket.emit (node:events:520:28)
    at Pipe. (node:net:339:12)

Generated by @jsenv/performance-impact during performance_impact#12545652239 on 6f1acf7

Copy link

Performance impact

Impact on 38 metrics when merging directory_list_workspaces into main. Before drawing conclusion, keep in mind performance variability.

package metrics (+0.1%)
Metric Before merge After merge Impact
import duration 0.09 second 0.09 second -0.001 second / -1% ↘️
import memory heap used 6.4 MB 6.4 MB +3.2 kB / +0.05% ↗️
import memory heap total 14.8 MB 15.1 MB +266 kB / +2% ↗️
import fs open operations 75 75 👻
import fs stat operations 146 146 👻
npm tarball size 344 kB 344 kB +656 B / +0.2% ↗️
npm tarball unpacked size 1.6 MB 1.6 MB +3.1 kB / +0.2% ↗️
npm tarball file count 206 206 👻
dev server metrics (+4%)
Metric Before merge After merge Impact
start duration 0.1 second 0.1 second -0.001 second / -0.9% ↘️
start memory heap used 6.8 MB 6.8 MB +4.2 kB / +0.06% ↗️
start memory heap total 23.8 MB 23.6 MB -258 kB / -1% ↘️
start fs read 0 0 👻
start fs write 0 0 👻
time to app display 0.5 second 0.5 second +0.003 second / +0.6% ↗️
serve app memory heap total 19.2 MB 19.2 MB 👻
serve app memory heap used 16.7 MB 16.7 MB -3.4 kB / -0.02% ↘️
serve app fs read 0 0 👻
serve app fs write 896 896 👻
time to 2nd app display 0.2 second 0.2 second +0.01 second / +8% ↗️
2nd serve memory heap total 2.4 MB 3.1 MB +786 kB / +33% ↗️
2nd serve memory heap used 623 kB 633 kB +9.6 kB / +2% ↗️
2nd serve fs read 0 0 👻
2nd serve fs write 896 896 👻
build metrics (+0.9%)
Metric Before merge After merge Impact
build duration 0.8 second 0.9 second +0.02 second / +3% ↗️
build memory heap used 32.9 MB 32.9 MB +7.3 kB / +0.02% ↗️
build memory heap total 66.2 MB 66.7 MB +528 kB / +0.8% ↗️
number of fs read operation 0 0 👻
number of fs write operation 264 264 👻
test metrics (+0.2%)
Metric Before merge After merge Impact
test plan duration 2.8 seconds 2.8 seconds +0.02 second / +0.7% ↗️
test plan memory heap used 43.9 MB 43.9 MB -3.7 kB / -0.008% ↘️
test plan memory heap total 88.4 MB 88.4 MB +4.1 kB / +0.005% ↗️
number of fs read operation 0 0 👻
number of fs write operation 1680 1680 👻
test metrics (serie) (-0.5%)
Metric Before merge After merge Impact
test plan duration 3.4 seconds 3.4 seconds -0.04 second / -1% ↘️
test plan memory heap used 43.9 MB 43.9 MB +16.8 kB / +0.04% ↗️
test plan memory heap total 88.4 MB 87.4 MB -1 MB / -1% ↘️
number of fs read operation 0 0 👻
number of fs write operation 1680 1680 👻
Generated by @jsenv/performance-impact during performance_impact#12544773913 on 9bcfa73

@dmail dmail marked this pull request as ready for review December 30, 2024 11:07
@dmail dmail merged commit e514fed into main Dec 30, 2024
1 of 8 checks passed
@dmail dmail deleted the directory_list_workspaces branch December 30, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant