Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix jsdoc param name #210

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Fix jsdoc param name #210

merged 2 commits into from
Feb 29, 2024

Conversation

cm-dyoshikawa
Copy link
Contributor

Fix validatorSettings to urlValidatorSettings.

@cm-dyoshikawa cm-dyoshikawa marked this pull request as ready for review February 16, 2024 02:32
@jshemas
Copy link
Owner

jshemas commented Feb 16, 2024

Good catch! Can you run npm run build and commit the new dist changes?

@cm-dyoshikawa
Copy link
Contributor Author

@jshemas Thank you for checking. I do it 😄

@jshemas
Copy link
Owner

jshemas commented Feb 29, 2024

Thank for the fix! Will publish with the next changeset

@jshemas jshemas merged commit 4f58bb9 into jshemas:master Feb 29, 2024
3 checks passed
@cm-dyoshikawa
Copy link
Contributor Author

Thank you for merging!

@cm-dyoshikawa cm-dyoshikawa deleted the fix-urlValidatorSettings branch February 29, 2024 00:58
@jshemas
Copy link
Owner

jshemas commented Mar 3, 2024

changes are live in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cm-dyoshikawa @jshemas