Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_fetch_startup] Use dynamicreconfigure to change speak volume of time_signal.py #1837

Merged
merged 7 commits into from
Jul 3, 2023
Merged

[jsk_fetch_startup] Use dynamicreconfigure to change speak volume of time_signal.py #1837

merged 7 commits into from
Jul 3, 2023

Conversation

tkmtnt7000
Copy link
Member

This PR enables us to change volume of time_signal.py from volume_lower/volume_reset app.

This change may help us avoid Fetch's noisy information voice.

c.f. PR2/app_manager#64

@tkmtnt7000
Copy link
Member Author

Thank you!

@tkmtnt7000 tkmtnt7000 merged commit 1406ce7 into jsk-ros-pkg:develop/fetch Jul 3, 2023
@tkmtnt7000 tkmtnt7000 deleted the enable-dynamic-reconfigure-time-signal branch July 3, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sktometometo sktometometo sktometometo approved these changes

Assignees
No one assigned
Labels
develop/fetch enhancement Fetch jsk_robot_startup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkmtnt7000 @sktometometo