Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_interactive_marker] Remove dependency on jsk_pcl_ros for separated build #623

Merged
merged 3 commits into from
Dec 14, 2016

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Aug 6, 2016

@wkentaro wkentaro changed the title Remove dependency: jsk_interactive_marker on jsk_pcl_ros for separated build [jsk_interactive_marker] Remove dependency on jsk_pcl_ros for separated build Aug 6, 2016
@k-okada
Copy link
Member

k-okada commented Aug 11, 2016

this requires to change client code if someone use this message, please confirm potential users.

@wkentaro
Copy link
Member Author

% rossrv md5 jsk_recognition_msgs/CallSnapIt
00529f1ccb0137f3a14b6d5b281f9a3c
% rossrv md5 jsk_pcl_ros/CallSnapIt
00529f1ccb0137f3a14b6d5b281f9a3c

The messages are completely the same, so I think there is no problem.
Tested as below:
https://gist.github.com/wkentaro/6ce45ce92ac615bd07d6072ed67c22e7

@wkentaro
Copy link
Member Author

wkentaro commented Dec 7, 2016

Could you please merge this?

@k-okada
Copy link
Member

k-okada commented Dec 11, 2016

sorry for late, did you run travis test after we merged jsk-ros-pkg/jsk_recognition#1983?

@wkentaro
Copy link
Member Author

No. Should I add test with installing from source?

@k-okada
Copy link
Member

k-okada commented Dec 12, 2016 via email

@wkentaro
Copy link
Member Author

That sounds good.

@k-okada
Copy link
Member

k-okada commented Dec 14, 2016

@wkentaro

13:14:14 [jsk_perception] -- Using these message generators: gencpp;geneus;genlisp;genpy 
13:14:16 [jsk_perception] CMake Error at /opt/ros/hydro/share/catkin/cmake/catkinConfig.cmake:75 (find_package): 
13:14:16 [jsk_perception]   Could not find a configuration file for package opencv_apps. 
13:14:16 [jsk_perception]  
13:14:16 [jsk_perception]   Set opencv_apps_DIR to the directory containing a CMake configuration file 
13:14:16 [jsk_perception]   for opencv_apps.  The file will have one of the following names: 
13:14:16 [jsk_perception]  
13:14:16 [jsk_perception]     opencv_appsConfig.cmake 
13:14:16 [jsk_perception]     opencv_apps-config.cmake 
13:14:16 [jsk_perception]  
13:14:16 [jsk_perception] Call Stack (most recent call first): 
13:14:16 [jsk_perception]   CMakeLists.txt:17 (find_package) 
13:14:16 [jsk_perception]  
13:14:16 [jsk_perception]  
13:14:16 [jsk_perception] -- [roseus.cmake] loading roseus.cmake from jsk_perception 
13:14:16 [jsk_perception] -- [roseus.cmake] roseus 1.3.9 

@wkentaro
Copy link
Member Author

wkentaro commented Dec 14, 2016

hydro?

@wkentaro
Copy link
Member Author

... why?

@wkentaro
Copy link
Member Author

Maybe because jsk_recognition is installed without version specification.
https://github.com/jsk-ros-pkg/jsk_visualization/blob/master/.travis.rosinstall.hydro#L1-L3

@k-okada
Copy link
Member

k-okada commented Dec 14, 2016

@wkentaro
Copy link
Member Author

wkentaro commented Dec 14, 2016

I think jsk-ros-pkg/jsk_recognition#1984 adds dependency on opencv_apps and released with 1.0.0 of jsk_recognition.
So jsk_visualization should depend on the 0.3.9 0.3.29, I think.

@wkentaro
Copy link
Member Author

[jsk_interactive_marker] /workspace/ros/ws_jsk_visualization/src/jsk_visualization/jsk_interactive_markers/jsk_interactive_marker/src/footstep_marker.cpp:45:45: fatal error: jsk_recognition_msgs/CallSnapIt.h: No such file or directory 

@k-okada k-okada merged commit 387a1b5 into jsk-ros-pkg:master Dec 14, 2016
@wkentaro wkentaro deleted the rm-pcl-dep branch December 14, 2016 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants