-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[jsk_interactive_marker] Remove dependency on jsk_pcl_ros for separated build #623
Conversation
this requires to change client code if someone use this message, please confirm potential users. |
The messages are completely the same, so I think there is no problem. |
Could you please merge this? |
sorry for late, did you run travis test after we merged jsk-ros-pkg/jsk_recognition#1983? |
No. Should I add test with installing from source? |
no you do not have to add new test, but let's restart travis job after new
release -> ros/rosdistro#13393
…--
◉ Kei Okada
2016-12-11 19:06 GMT+09:00 Kentaro Wada <[email protected]>:
No. Should I add test with installing from source?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#623 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3LIhNl12qW9O7zAgZOaNgp9M6abpks5rG8sfgaJpZM4JeRbf>
.
|
That sounds good. |
|
hydro? |
... why? |
Maybe because jsk_recognition is installed without version specification. |
I think jsk-ros-pkg/jsk_recognition#1984 adds dependency on opencv_apps and released with 1.0.0 of jsk_recognition. |
|
Depends on jsk-ros-pkg/jsk_recognition#1827