Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content negotiation: Enable override of chosen media type when Accept header is missing #1644

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

bkoelman
Copy link
Member

We need this to workaround a bug in NSwag: its generated client doesn't send an Accept header when only error responses define a content type.

QUALITY CHECKLIST

  • Changes implemented in code
  • Complies with our contributing guidelines
  • N/A: Adapted tests
  • N/A: Documentation updated

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.68%. Comparing base (0c79d35) to head (9573731).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1644   +/-   ##
=======================================
  Coverage   90.68%   90.68%           
=======================================
  Files         353      353           
  Lines       11514    11515    +1     
  Branches     1897     1898    +1     
=======================================
+ Hits        10441    10442    +1     
  Misses        702      702           
  Partials      371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review November 26, 2024 23:39
@bkoelman bkoelman merged commit 980a67d into master Nov 26, 2024
16 checks passed
@bkoelman bkoelman deleted the default-media-type branch November 26, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant