Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IJsonApiEndpointFilter: remove controller action methods at runtime #1646

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

bkoelman
Copy link
Member

This PR adds IJsonApiEndpointFilter, which enables to remove controller action methods at runtime. This comes in handy in tests, where variation is needed without relying on declarative GenerateControllerEndpoints usage.

QUALITY CHECKLIST

Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 85.48387% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.66%. Comparing base (980a67d) to head (5dd48c4).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...etCore/Middleware/HttpMethodAttributeExtensions.cs 81.81% 3 Missing and 3 partials ⚠️
...ore/Controllers/BaseJsonApiOperationsController.cs 71.42% 1 Missing and 1 partial ⚠️
...iDotNetCore/Middleware/JsonApiRoutingConvention.cs 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1646      +/-   ##
==========================================
- Coverage   90.68%   90.66%   -0.02%     
==========================================
  Files         353      355       +2     
  Lines       11515    11559      +44     
  Branches     1898     1905       +7     
==========================================
+ Hits        10442    10480      +38     
- Misses        702      705       +3     
- Partials      371      374       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review November 27, 2024 15:56
@bkoelman bkoelman merged commit c4dde57 into master Nov 27, 2024
16 checks passed
@bkoelman bkoelman deleted the endpoint-filter branch November 27, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant