Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced slices with arrays where appropriate #557

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Replaced slices with arrays where appropriate #557

wants to merge 3 commits into from

Conversation

m-manu
Copy link

@m-manu m-manu commented Jun 16, 2021 •
edited
Loading

Replaced slices with arrays at places in code that matched all 3 criteria:

  1. length is fixed (doesn't need to change throughout the lifecycle of the program)
  2. length is known at compile time
  3. isn't passed to another method as a parameter

m-manu added 2 commits June 16, 2021 19:51
@m-manu
Copy link
Author

m-manu commented Aug 24, 2021

This has been open for a couple of months now. Aren't maintainers looking at pull requests? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@m-manu