Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Bad contrast in the blog's dark theme in info boxes (#1070) #1131

Closed
wants to merge 1 commit into from

Conversation

ayushk-1801
Copy link

Fixed #1070

Added dark mode CSS so that the info boxes looks better.

image

@ayushk-1801 ayushk-1801 requested a review from a team as a code owner November 22, 2024 08:47
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.

Copy link

github-actions bot commented Nov 22, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview b60e91b

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (327f1ba) to head (b60e91b).
Report is 34 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1131   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          373       373           
  Branches        94        94           
=========================================
  Hits           373       373           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aialok
Copy link
Member

aialok commented Nov 23, 2024

@ayushk-1801 Thank you for the PR.

However, this issue still seems to persist. Could you please check and fix it?

https://ayushk-1801-main.website-2v2.pages.dev/blog/posts/applicability-json-schema-fundamentals-part-1#applicator-keywords

image

@ayushk-1801 ayushk-1801 closed this by deleting the head repository Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug: Bad contrast in the blog's dark theme in info boxes
2 participants