Fixing datetime convert code #117
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Opening ./test/test_data/missing_styles.xlsx in libre office and office365 shows '21.06.2019 02:39:12' So testing against 02:39:11 was a mistake. (now tests are broken)
This is the use case that made me discover the bug that will be fixed in next commit. 0.395833333333333 should be interpreted as 9h30mn0s but actual code interprets it as 9h29mn59s
This commit has no functional changes, only applying now standard 'mix format' command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix issue #115
It seems that one of the test case was actually false ... please try to open missing_styles.xlsx in excel and see that it actually shows '2h39m12s' and not '2h39m11s'
I also made some cleanup (removing empty config.exs file and doing mix formating)