fix demo highlighting #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: c7058bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
acao
reviewed
Jun 5, 2024
| "@codemirror/state": "^6.2.1", | ||
| "@codemirror/view": "^6.14.1", | ||
| "@lezer/common": "^1.0.3" | ||
| "@codemirror/language": "^6.10.2", |
There was a problem hiding this comment.
are we certain users need this version? our example repo seems fine with an earlier version, same for other peers
acao
approved these changes
Jun 5, 2024
Merged
acao
pushed a commit
that referenced
this pull request
Jun 5, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#122](#122) [`c2dfcc1`](c2dfcc1) Thanks [@imolorhe](https://github.com/imolorhe)! - fix demo highlighting - [#123](#123) [`2356a94`](2356a94) Thanks [@imolorhe](https://github.com/imolorhe)! - updated json-schema-library to get upstream fixes Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Codemirror misbehaves when relevant package versions are out of sync, or if there are multiple versions of the same package being used. I updated all the packages to the latest versions, and deduped to remove any duplicated package versions