-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move non runtime packages to dev dependencies #139
Conversation
🦋 Changeset detectedLatest commit: a65066d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c611d89
to
dcc704f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the lock file isn't updated. Deploys are failing
Ah, sorry. I'm unfamiliar with
And it looks like that has updated the lockfile. I didn't see a Off the top of my head I can think about:
|
thanks for this, Nick! you're one of our first outside contributors, sorry for that oversight, but either way I'll be sure to add a contributing.md moving forward! looks like the install worked by the way! just one failing test now, I will check back later when i get home |
👍 np! Thank you for the quick response |
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## [email protected] ### Patch Changes - [#133](#133) [`4fd7cc6`](4fd7cc6) Thanks [@imolorhe](https://github.com/imolorhe)! - Get sub schema using parsed data for additional context - [#137](#137) [`29e2da5`](29e2da5) Thanks [@xdavidwu](https://github.com/xdavidwu)! - Fix description markdown rendering in completion - [#144](#144) [`ef7f336`](ef7f336) Thanks [@imolorhe](https://github.com/imolorhe)! - updated to use fine grained shiki bundle - [#139](#139) [`bfbe613`](bfbe613) Thanks [@NickTomlin](https://github.com/NickTomlin)! - Move non essential packages to devDependencies - [#140](#140) [`bceace2`](bceace2) Thanks [@NickTomlin](https://github.com/NickTomlin)! - Add CONTRIBUTING.md file Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
I noticed these packages were bringing in some extra dependencies of their own but seem unused except for internal development.