Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move non runtime packages to dev dependencies #139

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

NickTomlin
Copy link
Contributor

I noticed these packages were bringing in some extra dependencies of their own but seem unused except for internal development.

Copy link

changeset-bot bot commented Aug 30, 2024

🦋 Changeset detected

Latest commit: a65066d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Aug 30, 2024

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit a65066d
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/66d73372fabff20008da15c2
😎 Deploy Preview https://deploy-preview-139--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@imolorhe imolorhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the lock file isn't updated. Deploys are failing

@NickTomlin
Copy link
Contributor Author

NickTomlin commented Sep 3, 2024

Ah, sorry. I'm unfamiliar with pnpm I've gone ahead and run

npx [email protected] install

And it looks like that has updated the lockfile.

I didn't see a CONTRIBUTING.md file or dev instructions in the README and I'd be happy to open a PR with a file like that with some basic how-to's if that would be helpful.

Off the top of my head I can think about:

  • Development setup (using pnpm)
  • Tests (adding tests, running tests locally, etc)
  • How to use changeset to describe PR

@acao
Copy link
Collaborator

acao commented Sep 5, 2024

thanks for this, Nick! you're one of our first outside contributors, sorry for that oversight, but either way I'll be sure to add a contributing.md moving forward!

looks like the install worked by the way! just one failing test now, I will check back later when i get home

@NickTomlin NickTomlin mentioned this pull request Sep 5, 2024
@NickTomlin
Copy link
Contributor Author

👍 np! Thank you for the quick response

@acao acao merged commit bfbe613 into jsonnext:main Sep 7, 2024
5 checks passed
@NickTomlin NickTomlin deleted the ntomlin/slim-deps branch September 9, 2024 15:31
@github-actions github-actions bot mentioned this pull request Sep 7, 2024
imolorhe pushed a commit that referenced this pull request Nov 16, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#133](#133)
[`4fd7cc6`](4fd7cc6)
Thanks [@imolorhe](https://github.com/imolorhe)! - Get sub schema using
parsed data for additional context

- [#137](#137)
[`29e2da5`](29e2da5)
Thanks [@xdavidwu](https://github.com/xdavidwu)! - Fix description
markdown rendering in completion

- [#144](#144)
[`ef7f336`](ef7f336)
Thanks [@imolorhe](https://github.com/imolorhe)! - updated to use fine
grained shiki bundle

- [#139](#139)
[`bfbe613`](bfbe613)
Thanks [@NickTomlin](https://github.com/NickTomlin)! - Move non
essential packages to devDependencies

- [#140](#140)
[`bceace2`](bceace2)
Thanks [@NickTomlin](https://github.com/NickTomlin)! - Add
CONTRIBUTING.md file

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants