Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade json schema lib, replace backticks with code blocks, no value context bug #64

Merged
merged 6 commits into from
Dec 4, 2023

Conversation

acao
Copy link
Collaborator

@acao acao commented Aug 19, 2023

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Aug 19, 2023

🦋 Changeset detected

Latest commit: 479fb8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-json-schema Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Aug 19, 2023

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit 479fb8f
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/656d1c2210f67900082ef627
😎 Deploy Preview https://deploy-preview-64--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acao acao force-pushed the upgrade-json-schema-lib branch 3 times, most recently from 312e8c5 to 7ccd833 Compare November 8, 2023 09:36
@acao acao changed the title upgrade json schema lib, replace backticks with code blocks, bug for no value context upgrade json schema lib, replace backticks with code blocks, no value context bug Nov 8, 2023
@acao
Copy link
Collaborator Author

acao commented Nov 8, 2023

oof - found a bug in this one - the hover doesn't show description anymore

@acao acao merged commit 0aaf308 into main Dec 4, 2023
3 checks passed
@acao acao deleted the upgrade-json-schema-lib branch December 4, 2023 00:24
acao added a commit that referenced this pull request Dec 4, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Minor Changes

- [#64](#64)
[`0aaf308`](0aaf308)
Thanks [@acao](https://github.com/acao)! - **Breaking Change**: replaces
backticks with `<code>` blocks in hover and completion! This just seemed
to make more sense.

- upgrade `json-schema-library` to the latest 8.x with patch fixes,
remove "forked" pointer step logic
- after autocompleting a property, when there is empty value, provide
full autocomplete options
- as noted in the breaking change notice, all psuedo-markdown backtick
\`\`delimiters are replaced with`<code>`

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rikki Schulte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant