Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove json-schema #65

Closed
wants to merge 2 commits into from
Closed

Conversation

AlexErrant
Copy link

It is unused (I think, since pnpm build and pnpm test pass for me locally) and more importantly Dependabot is yowling at me that 0.2.3 has a "Critical" CVE, (which I don't mind talking about publically because you don't use this dep).

image

@changeset-bot
Copy link

changeset-bot bot commented Sep 27, 2023

🦋 Changeset detected

Latest commit: 4d0efa5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
codemirror-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for codemirror-json-schema ready!

Name Link
🔨 Latest commit 4d0efa5
🔍 Latest deploy log https://app.netlify.com/sites/codemirror-json-schema/deploys/651485f2d3106e000752e719
😎 Deploy Preview https://deploy-preview-65--codemirror-json-schema.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@acao
Copy link
Collaborator

acao commented Nov 6, 2023

strange, it must still be resolving the imports from another package shipping with this dependency. I will look into this some more!

@acao
Copy link
Collaborator

acao commented Nov 6, 2023

@AlexErrant in #70 I managed to upgrade to the latest version. I would like to keep it as it is a type dependency. thanks for this and for reporting the issue!

@AlexErrant AlexErrant closed this Nov 6, 2023
@AlexErrant AlexErrant deleted the nix-json-schema branch November 6, 2023 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants