Add a nested object case with non-determinism #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-determinism comes from the descendant traversal ordering rules as well as from the unordered nature of objects.
jg-rp
approved these changes
Mar 20, 2024
|
@gregsdennis Please could you take a look. I want to make sure we are all on the same page with these tests. |
gregsdennis
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
This looks good to me. Passes for me, and the permutations look right.
@jg-rp can you run your thing to verify the permutations, please?
f3ath
approved these changes
Mar 21, 2024
Have done. Looks good to me. |
|
@glyn not sure why this can't merge. Can you investigate, please? |
|
Will do. AFK ATM.
…On Thu, 21 Mar 2024, 07:09 Greg Dennis, ***@***.***> wrote:
@glyn <https://github.com/glyn> not sure why this can't merge. Can you
investigate, please?
—
Reply to this email directly, view it on GitHub
<#68 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAXF2MATDVQ7EMTMQV5CD3YZKBRZAVCNFSM6AAAAABE6VXC7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMJRGM2TAMJVGY>
.
You are receiving this because you were mentioned.Message ID:
<jsonpath-standard/jsonpath-compliance-test-suite/pull/68/c2011350156@
github.com>
|
|
@gregsdennis The branch protection rule I added was over-zealous and was locking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-determinism comes from the descendant traversal ordering rules as well as from the unordered nature of objects.
(Please note that this was accidentally pushed to main earlier and then reverted. A branch protection rule is now in place!)