first changes to homework #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tech-J
reviewed
Oct 10, 2019
Comment on lines
30
to
46
| console.log('Problem 1:') | ||
|
|
||
| // Add your code below this line | ||
|
|
||
| function blackJack(playerCardScore, dealerCardScore) { | ||
| if (playerCardScore <= 21 && dealerCardScore <= 21) { | ||
| return Math.max(playerCardScore, dealerCardScore) | ||
| } else if (playerCardScore <= 21) { | ||
| return playerCardScore | ||
| } else if (dealerCardScore <= 21) { | ||
| return dealerCardScore | ||
| } else { | ||
| return 0 | ||
| } | ||
| } | ||
|
|
||
| console.log(blackJack(19, 21)) | ||
| // Add your code above this line |
Tech-J
reviewed
Oct 10, 2019
Comment on lines
102
to
119
| console.log('Problem 2:') | ||
|
|
||
| // Add your code below this line | ||
| function wordCount(phrase) { | ||
| const wordPhrase = phrase.replace(/[,]/g, '') | ||
| const wordCountObject = {} | ||
|
|
||
| wordPhrase.split(' ').forEach(function (currentValue) { | ||
| wordCountObject[currentValue] = wordCountObject[currentValue] ? ++wordCountObject[currentValue] : 1 | ||
| }) | ||
|
|
||
| return wordCountObject | ||
| } | ||
|
|
||
| const result = wordCount("Humpty Dumpty sat on a wall Humpty Dumpty had a great fall") | ||
|
|
||
| console.log(result) | ||
| // Add your code above this line |
There was a problem hiding this comment.
@OcielC Good job here putting together this solution. Good use of chaining the split and forEach methods and using the conditional ternary operator to either add the new word to the object with the value of 1 or find the word in the object if it exists and increment the value by 1.
Take a look at an alternate solution here
Tech-J
reviewed
Oct 10, 2019
Comment on lines
160
to
179
| console.log('Problem 3:') | ||
|
|
||
| // Add your code below this line | ||
|
|
||
| function scrabbleScore(word) { | ||
| const letters = word.split(' ') | ||
| const wordCount = {} | ||
|
|
||
| letters.forEach((letter) => { | ||
| if (wordCount[letter] === undefined) { | ||
| wordCount[letter] = 1 | ||
| } else { | ||
| wordCount[letter] += 1 | ||
| } | ||
| // console.log(wordCount) | ||
| }) | ||
| return wordCount | ||
| } | ||
|
|
||
| console.log(scrabbleScore('cabbage')) | ||
| // Add your code above this line |
There was a problem hiding this comment.
@OcielC Good work coming up with this solution here. for this assignment, it needed to be done slightly different. This solution would work well for problem 3 and this problem here you had to compare each letter of the string with a letter that will give you a certain amount of points per letter.
Take a look at this solution here
Tech-J
reviewed
Oct 10, 2019
Comment on lines
214
to
223
| console.log('Problem 4:') | ||
|
|
||
| // Add your code below this line | ||
| function isPalindrome(word, i = 0) { | ||
| const j = word.length - 1 - i; | ||
| return i >= j ? true : word[i] === word[j] && isPalindrome(word, i + 1); | ||
| } | ||
|
|
||
| console.log(isPalindrome('run')) | ||
| // Add your code above this line |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.