Homework 2- Natalie Mikhol #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tech-J
reviewed
Oct 10, 2019
Comment on lines
+34
to
+46
| function blackJack(playerCardScore, dealerCardScore ){ | ||
|
|
||
| if(playerCardScore > 21 && dealerCardScore > 21){ | ||
| return 0 | ||
| } else if (playerCardScore > dealerCardScore && playerCardScore <= 21 || dealerCardScore > 21){ | ||
| return playerCardScore | ||
| } else { | ||
| return dealerCardScore | ||
| } | ||
| } | ||
|
|
||
| console.log(blackJack(19, 22)) | ||
|
|
Tech-J
reviewed
Oct 10, 2019
Comment on lines
+107
to
+123
| function wordCount(phrase){ | ||
| const cleanedPhrase = phrase.replace(/[,.]/g, '') | ||
| const splitWords = cleanedPhrase.split(' ') | ||
| const wordCount = {} | ||
|
|
||
| splitWords.forEach((splitWord) => { | ||
| if(wordCount[splitWord] === undefined) { | ||
| wordCount[splitWord] = 1 | ||
| } else { | ||
| wordCount[splitWord] += 1 | ||
| } | ||
| }) | ||
| return wordCount | ||
|
|
||
| } | ||
|
|
||
| console.log(wordCount("Baby shark, doo doo doo doo doo doo")) |
Tech-J
reviewed
Oct 10, 2019
Comment on lines
166
to
+208
| console.log('Problem 3:') | ||
|
|
||
| // Add your code below this line | ||
| function scrabbleScore(word){ | ||
| const splitLetters = word.split("") | ||
| let sum = 0 | ||
| const points = { | ||
| a: 1, | ||
| b: 3, | ||
| c: 3, | ||
| d: 2, | ||
| e: 1, | ||
| f: 4, | ||
| g: 2, | ||
| h: 4, | ||
| i: 1, | ||
| j: 8, | ||
| k: 5, | ||
| l: 1, | ||
| m: 3, | ||
| n: 1, | ||
| o: 1, | ||
| p: 3, | ||
| q: 10, | ||
| r: 1, | ||
| s: 1, | ||
| t: 1, | ||
| u: 1, | ||
| v: 4, | ||
| w: 4, | ||
| x: 8, | ||
| y: 4, | ||
| z: 10 | ||
| } | ||
|
|
||
| splitLetters.forEach((splitLetter) => { | ||
| sum += points[splitLetter] | ||
| }) | ||
|
|
||
| return sum | ||
| } | ||
|
|
||
| console.log(scrabbleScore("javascript")) |
Tech-J
reviewed
Oct 10, 2019
Comment on lines
+249
to
+260
| function isPalindrome(word){ | ||
| let splitWords = word.split('') | ||
| let reversedArr = splitWords.reverse() | ||
| let reversedWord = reversedArr.join("") | ||
| if(word === reversedWord){ | ||
| return true | ||
| } else{ | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| console.log(isPalindrome("noon")) |
There was a problem hiding this comment.
Tech-J
reviewed
Oct 10, 2019
Comment on lines
+312
to
+323
| function doubleLetters(word){ | ||
| let letters = word.split('') | ||
| let result = false | ||
| letters.forEach((letter, index) => { | ||
| if (letter === letters[index+1]){ | ||
| result = true | ||
| } | ||
| }) | ||
| return result | ||
| } | ||
|
|
||
| console.log(doubleLetters("rune")) |
There was a problem hiding this comment.
@nmikhol Good job on this problem here. I see you split the word into an array and your looping through each element checking to see the current and next letter match, Good job on that. One suggestion instead of creating the variable result and changing it to true of false, Since your using a boolean you can return true and return result explicitly instead of changing it through a variable. since your looking for the consecutive letter in a word once you find the consecutive repeating word if you return true that would stop the program since you arrived at an answer.
Take a look at an alternate solution here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having trouble with problem 5