Completed Homework Assignment #4 - Caleb Sanchez #1
Conversation
| botChoice = Math.floor(Math.random() * 3) + 1 | ||
|
|
||
| //If statement to assign numbers to string choices | ||
| if (botChoice === 1) { | ||
| botChoice = 'rock' | ||
| } else if (botChoice === 2) { | ||
| botChoice = 'scissors' | ||
| } else if (botChoice === 3) { | ||
| botChoice = 'paper' | ||
| } else { | ||
| console.log('Invalid choice.') | ||
| } |
There was a problem hiding this comment.
@cswebdesign botChoice will either be 1, 2, or 3. if it's not 1 or 2, then we can assume it'll be 3, so line 33 could be replaced with a simple else statement. line 35 will never run, but it's great that you're thinking about edge cases and error handling. 👍
An alternative solution could be to store the choices in an array and access them via index (minus the 1).
check solution here
| //Function to compare choices, declare a winner, and reward points | ||
| function determineWinner() { | ||
| if ( userChoice === botChoice ) { | ||
| $('#status').html(`<p>You chose <b><u>${userChoice}</u></b>. The bot chose <b><u>${botChoice}</u></b>.</p><p>Tie game!</p>`) |
There was a problem hiding this comment.
@cswebdesign the only part that changes in the status is the userChoice and botChoice. Because the string is used several times, you may want to consider encapsulating it into a function.
Here is the alternative approach
| function roundOneWinner() { | ||
| if(botScore >= 10) { | ||
| $('#wise-message').text('Round 1 Winner: Bot') | ||
| $('body').css('color', 'yellow') | ||
| $('button').css('background', 'yellow') | ||
| $('.scoreboard').css('borderColor', 'yellow') | ||
| $('.scoreboard h2').css('borderBottomColor', 'yellow') | ||
| } else if(userScore >= 10) { | ||
| $('#wise-message').text('Round 1 Winner: You') | ||
| $('body').css('color', 'yellow') | ||
| $('button').css('background', 'yellow') | ||
| $('.scoreboard').css('borderColor', 'yellow') | ||
| $('.scoreboard h2').css('borderBottomColor', 'yellow') | ||
| } | ||
| } |
There was a problem hiding this comment.
@cswebdesign Great job on breaking each logical portion into separate functions. To conform to the DRY principle and get the most out of the functions, consider passing arguments through so it can be extended in other parts of your code. This can be reused in the roundTwoWinner function, but there are certainly many ways to solve this.
Great effort on the extra features!! 🥇
check the solution for how things are being compared
*The consecutive win option was an awesome problem that had me frustrated for awhile. The solution ended up being far more simple than what I started with.