Homework-04 #5
Homework-04 #5
Conversation
There was a problem hiding this comment.
@AtleLohrmann Great work on the rock-scissor-paper game!! 👍
Excellent job on the commenting and separation of logic using functions. 💯
|
|
||
| // If the user clicks "rock": | ||
| $('#rock').click(() => { | ||
| let userInput = $('#rock').text() |
There was a problem hiding this comment.
@AtleLohrmann you can also grab the text from $(this) because this would refer to the object clicked.
Also, because we know which button was clicked, you can use an inline string with the respective button's value.
check out this approach
| // generate a random integer [0:2] | ||
| let randomInt = getRandomInt(3) | ||
| if (randomInt===0) { | ||
| choice='rock' |
There was a problem hiding this comment.
@AtleLohrmann this is a functionally scoped var declaration. just curious why you switched from es6 to es5. It still works, so no worries there.
| } else { | ||
| alert('something wrong with the getMachineInput routine [0:2]:' + randomInt) | ||
| } |
There was a problem hiding this comment.
@AtleLohrmann Great use case for error handling. However, this statement would never run because of the randomly generated number.
| let machineInput=NaN | ||
| let userInput=NaN |
There was a problem hiding this comment.
@AtleLohrmann The input corresponds to a string when it's assigned, so having either an empty string or null would be a better candidate for a default value. However, Great job on experimenting with other data types for default values.
| // Extra info for the user for clarity and also debugging -- a little awkward but it works | ||
| if (winner===1) {gwin="User"} else {gwin="Bot"} //transfer winner to text that we can use | ||
| $('#status').html("Computer played " + '<u>'+machineInput+'</u>' + '.' + '\n' | ||
| + "You played " + '<u>'+userInput+'</u>'+'.' + '</br>' + gwin + " Won" ) |
There was a problem hiding this comment.
@AtleLohrmann the UI does not account for tied games
check solution here
I have not done the optional work - did not notice it before it had been uploaded. I do need to work more on jQuery so I will redo some of the earlier "code-alongs" to practice