Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homework 4 Complete- Natalie Mikhol #6

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nmikhol
Copy link

@nmikhol nmikhol commented Oct 14, 2019

No description provided.

@nmikhol nmikhol changed the title Home 4 Complete- Natalie Mikhol Homework 4 Complete- Natalie Mikhol Oct 14, 2019
Copy link

@aghaffar570 aghaffar570 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmikhol Great job on the rock-scissor-paper game!! Clean and concise code and great use of breaking code blocks/logic into separate functions. 💯 ✨ ✨

Comment on lines +40 to +42
clearStatus()
$('#status').append(`You played <u>${playerChoice}</u>. The bot played <u>${botChoice}</u>. You Lose :(`)
$('#computerScore').html(botScore += 1)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nmikhol the compare function does the job, but this code snippet could be extended into another function that updates the status with the respective score and choices passed as arguments.

Check out this approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants