Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CoffeeScript 2+ #16

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Support CoffeeScript 2+ #16

wants to merge 9 commits into from

Conversation

ylxdzsw
Copy link

@ylxdzsw ylxdzsw commented Jun 13, 2019

Updated w.r.t. @ForbesLindesay 's comments in #15

@ylxdzsw ylxdzsw mentioned this pull request Jun 13, 2019
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #16 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #16   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           8      8           
  Branches        1      1           
=====================================
  Hits            8      8
Impacted Files Coverage Δ
index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10c9a1b...e5ab9d3. Read the comment docs.

@kenOfYugen
Copy link

kenOfYugen commented May 10, 2020

Bump @ForbesLindesay @calebeby @hemanth @RobLoach @TimothyGu @tunnckoCore

Copy link
Member

@tunnckoCore tunnckoCore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should name it jstransformer-coffeescript or make another transformer, idk. I'm not very active...

@edemaine
Copy link

edemaine commented May 26, 2021

Feeling the lack of this when using Pug. Could it get merged and published?

I do think jstransformer-coffeescript would be a more consistent naming scheme (given the coffee-script to coffeescript rename). But given the major version bump, I don't think it matters either way.

Related: It might be nice to specify coffeescript as a peer dependency, so that we can bring whatever version we want.

@edemaine
Copy link

edemaine commented Aug 3, 2021

To be more specific: I think this can be merged and published as-is. It would be greatly appreciated! (I'd also be willing to help maintain this package if that's desired.)

Optionally, you could rename the package, but I don't think that's important.

I can make a separate PR for peer dependency if that would be helpful. This is probably less important, as CoffeeScript doesn't get new releases that often.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants