feat(jstzd): docker container #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
ryutamago
commented
Sep 17, 2024
crates/jstzd/src/docker/container.rs
Outdated
Comment on lines
36
to
45
| pub async fn cleanup(&self) -> Result<()> { | ||
| self.stop() | ||
| .await | ||
| .unwrap_or_else(|e| error!("Error stopping container: {}", e)); | ||
| match self.client()?.remove_container(&self.id, None).await { | ||
| Ok(_) => {} | ||
| Err(e) => error!("Error removing container {}: {}", self.id, e), | ||
| } | ||
| Ok(()) |
ryutamago
force-pushed
the
leo/docker-pull-image
branch
3 times, most recently
from
c2c89f5
to
d418e66
Compare
ryutamago
force-pushed
the
leo/docker-container
branch
3 times, most recently
from
baf27fb
to
d678a00
Compare
ryutamago
force-pushed
the
leo/docker-pull-image
branch
from
d418e66
to
f9b4724
Compare
ryutamago
force-pushed
the
leo/docker-container
branch
from
d678a00
to
65c107e
Compare
ryutamago
force-pushed
the
leo/docker-pull-image
branch
from
f9b4724
to
934d878
Compare
ryutamago
force-pushed
the
leo/docker-container
branch
from
65c107e
to
c06bb9a
Compare
ryutamago
force-pushed
the
leo/docker-pull-image
branch
3 times, most recently
from
934d878
to
df8eb4d
Compare
ryutamago
force-pushed
the
leo/docker-container
branch
from
416a63e
to
f14da3a
Compare
ryutamago
force-pushed
the
leo/docker-container
branch
from
f14da3a
to
2f1f863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
runnable_image create
container
Description
implement the create method on runnable image and docker container
Manually testing the PR
run
cargo test --package jstzd