Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstz_engine): add safe wrapper for JS Scripts #660

Open
wants to merge 1 commit into
base: ajob410@jstz-192-add-realm
Choose a base branch
from

Conversation

johnyob
Copy link
Collaborator

@johnyob johnyob commented Nov 14, 2024

Context

Adds memory and type-safe version of JSScript.

Description

Adds ability to compile and evaluate scripts.

Manually testing the PR

cargo nextest run --package jstz_engine

@johnyob johnyob self-assigned this Nov 14, 2024
@johnyob johnyob force-pushed the ajob410@jstz-192-add-realm branch 3 times, most recently from 44c2372 to 370d8b4 Compare November 27, 2024 17:14
@johnyob johnyob force-pushed the ajob410@jstz-193-add-script branch 2 times, most recently from 1694cb5 to 0a803c7 Compare November 27, 2024 17:29
@johnyob johnyob requested a review from zcabter November 27, 2024 17:30
@johnyob johnyob marked this pull request as ready for review November 27, 2024 17:30
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 67.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 45.69%. Comparing base (4d1d373) to head (9106c11).

Files with missing lines Patch % Lines
crates/jstz_engine/src/script.rs 67.00% 32 Missing and 1 partial ⚠️
Files with missing lines Coverage Δ
crates/jstz_engine/src/lib.rs 100.00% <ø> (ø)
crates/jstz_engine/src/script.rs 23.42% <67.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d1d373...9106c11. Read the comment docs.

@johnyob johnyob assigned zcabter and unassigned johnyob Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants