feat(jstzd): spwan rollup in jstzd server #666
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/jstzd/tests/jstzd_test.rs
Outdated
| @@ -164,18 +280,12 @@ async fn read_bootstrap_contracts() -> Vec<BootstrapContract> { | |||
| contracts | |||
| } | |||
|
|
|||
| async fn check_bootstrap_contracts(octez_client: &OctezClient) { | |||
There was a problem hiding this comment.
You can move this function back to this position from above so that there are fewer lines modified
crates/jstzd/tests/jstzd_test.rs
Outdated
| rollup_parameters_ty: &Path, | ||
| ) -> ProtocolParameter { | ||
| ProtocolParameterBuilder::new() | ||
| // this is the activator account |
There was a problem hiding this comment.
The comment here needs to be updated
crates/jstzd/tests/jstzd_test.rs
Outdated
| let baker_destroyed = retry(30, 1000, || async { | ||
| Ok(!run_ps().await.contains("octez-baker")) | ||
| }) | ||
| .await; | ||
| assert!(baker_destroyed); | ||
|
|
||
| let rollup_destroyed = retry(30, 1000, || async { |
There was a problem hiding this comment.
This might not always work. See #664.
There was a problem hiding this comment.
i will use the health check method for now and can use the approach later
| use std::path::{Path, PathBuf}; | ||
| use tezos_crypto_rs::hash::{BlockHash, OperationHash, SmartRollupHash}; | ||
| use tokio::io::AsyncReadExt; | ||
|
|
||
| pub const ACTIVATOR_SECRET_KEY: &str = | ||
| "unencrypted:edsk31vznjHSSpGExDMHYASz45VZqXN4DPxvsa4hAyY8dHM28cZzp6"; | ||
| pub const ROLLUP_ADDRESS: &str = "sr1PuFMgaRUN12rKQ3J2ae5psNtwCxPNmGNK"; |
There was a problem hiding this comment.
Does the address need to change?
There was a problem hiding this comment.
yes, i've changed the toy rollup address in sandbox-params.json due to the conflict w JSTZ_ROLLUP_ADDRESS
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-1
branch
from
ebde2de to
cb07043
Compare
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-2
branch
2 times, most recently
from
3dcf8bc to
97468a0
Compare
ryutamago
force-pushed
the
leounoki-jstz-164/spawn-rollup-2
branch
from
97468a0 to
0c16731
Compare
|
closing for this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Spawn rollup in jstzd
Description
NOTE: it could be helpful to have a script that will generate the jstzd binaries in the future but for now we can just manually add them.
Manually testing the PR
integration test: