feat(jstzd): launch jstzd server with cli #685
+71
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-7
branch
from
5ef5615
to
ed89ae9
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
0f93c72
to
324afd1
Compare
Codecov ReportAttention: Patch coverage is
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-7
branch
from
ed89ae9
to
05b4280
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
324afd1
to
823b3bc
Compare
huancheng-trili
changed the base branch from
huanchengchang-jstz-168-7
to
huanchengchang-jstz-168-8
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
3 times, most recently
from
9b750d2
to
3634975
Compare
huancheng-trili
changed the title
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-8
branch
2 times, most recently
from
3a00b63
to
b79b8e9
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
3634975
to
8f641be
Compare
huancheng-trili
changed the base branch from
huanchengchang-jstz-168-8
to
huanchengchang-jstz-168-9
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
3 times, most recently
from
c259d03
to
797bb89
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-9
branch
from
d054009
to
0fbc41e
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
3 times, most recently
from
620f38f
to
afc6f81
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-9
branch
from
0fbc41e
to
efd416c
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
afc6f81
to
cefaabc
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-9
branch
from
efd416c
to
da0470e
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
cefaabc
to
f69ed4b
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-9
branch
from
da0470e
to
dcddb24
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
f69ed4b
to
a09fb96
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-9
branch
from
dcddb24
to
6e2db30
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
a09fb96
to
27a422d
Compare
ryutamago
reviewed
Dec 2, 2024
| .is_success()); | ||
| handle | ||
| .join() | ||
| .expect("jstzd should have been taken down without any error"); |
There was a problem hiding this comment.
add a TODO for checking the rollup / jstz_node later?
huancheng-trili
force-pushed
the
huanchengchang-jstz-168-9
branch
from
6e2db30
to
bb610b7
Compare
huancheng-trili
force-pushed
the
huanchengchang-jstz-168
branch
from
27a422d
to
4fd53ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Completes JSTZ-168.
JSTZ-168
Description
Spins up jstzd server on
jstzd run <config_path>. It makes things easier if we wait a bit for jstzd before spinning up jstzd server, so I made some changes to that part.Threading is necessary in the tests because
assert_cmdunfortunately does not handle async yet.Manually testing the PR