Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leounoki jstz 165/spawn jstz node 2 #687

Open
wants to merge 4 commits into
base: leounoki-jstz-164/spawn-rollup-3
Choose a base branch
from

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Nov 25, 2024

Context

task

The ci fails for the same reason as the rollup PR

Description

  • spawn jstz-node in jstzd
  • introduce a type aliass Shared and refactored the jstzd by adding a blanket implementation so we can avoid having to write Arc<RwLock<.. everywhere

Manually testing the PR

add integration tests the runs successfully locally

nix flake check

@ryutamago ryutamago changed the base branch from main to leounoki-jstz-164/spawn-rollup-3 November 25, 2024 12:37
@ryutamago ryutamago force-pushed the leounoki-jstz-165/spawn-jstz-node-2 branch 2 times, most recently from 3bc826a to 9b93c64 Compare November 26, 2024 14:43
@ryutamago ryutamago marked this pull request as ready for review November 26, 2024 14:54
@ryutamago ryutamago force-pushed the leounoki-jstz-164/spawn-rollup-3 branch from 0dc68a8 to 3933223 Compare November 29, 2024 13:32
@ryutamago ryutamago force-pushed the leounoki-jstz-165/spawn-jstz-node-2 branch from 9b93c64 to 67bff8b Compare November 29, 2024 13:36
@@ -1,4 +1,7 @@
use super::{
// child_wrapper::Shared,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// child_wrapper::Shared,

@ryutamago ryutamago force-pushed the leounoki-jstz-164/spawn-rollup-3 branch 4 times, most recently from 7e1bb8d to 8e7f0c0 Compare December 3, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants