Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jstz proto: introduce new account #758

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

ryutamago
Copy link
Collaborator

@ryutamago ryutamago commented Jan 12, 2025

Context

first step of migrarting to a new account
task link
in preparation for 255

Description

Added a new account context that handles address of both user and smart function. For a clearer api, we should use SmartFunctionHash for methods that's only intended for sf. This can be implemented after the migration to the new account type is completed.

In the next step, the old account should be replaced with the new one.

Manually testing the PR

Unit tests are added.

@ryutamago ryutamago changed the title feat(jstz_proto): introduce new account jstz proto: introduce new account Jan 12, 2025
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 88.63198% with 59 lines in your changes missing coverage. Please review.

Project coverage is 49.21%. Comparing base (345123f) to head (513e63a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/jstz_proto/src/context/new_account.rs 88.80% 23 Missing and 35 partials ⚠️
crates/jstz_proto/src/error.rs 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
crates/jstz_proto/src/error.rs 20.00% <0.00%> (-0.28%) ⬇️
crates/jstz_proto/src/context/new_account.rs 89.11% <88.80%> (-6.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 345123f...513e63a. Read the comment docs.

@ryutamago ryutamago self-assigned this Jan 12, 2025
@ryutamago ryutamago marked this pull request as ready for review January 13, 2025 10:19
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch 2 times, most recently from 42a6381 to 6360e44 Compare January 13, 2025 12:12
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-prep branch from 3a0196c to c7a8f38 Compare January 13, 2025 13:25
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch from 6360e44 to ab024ef Compare January 13, 2025 13:26
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-prep branch from c7a8f38 to 3bbf375 Compare January 13, 2025 14:01
Base automatically changed from leounoki-jstz-257/introduce-new-account-prep to main January 13, 2025 21:20
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch 3 times, most recently from 0a2db5c to e8957be Compare January 13, 2025 22:19
@ryutamago ryutamago assigned zcabter and unassigned huancheng-trili Jan 14, 2025
@zcabter
Copy link
Collaborator

zcabter commented Jan 14, 2025

To aid with review, it would be helpful to add the specific commands that execute your tests in the "Manual Testing" section.

@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch from e8957be to f1945d2 Compare January 14, 2025 16:36
@zcabter
Copy link
Collaborator

zcabter commented Jan 14, 2025

LGTM overall. Good job. 🚀

@zcabter zcabter assigned ryutamago and unassigned zcabter Jan 14, 2025
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch 2 times, most recently from 40e4cf7 to a1ac76e Compare January 15, 2025 14:47
@ryutamago ryutamago requested a review from zcabter January 15, 2025 15:08
@ryutamago ryutamago assigned zcabter and unassigned ryutamago Jan 15, 2025
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch from a1ac76e to 64d7802 Compare January 16, 2025 16:16
@zcabter zcabter assigned ryutamago and unassigned zcabter Jan 17, 2025
@ryutamago ryutamago force-pushed the leounoki-jstz-257/introduce-new-account-type branch from 64d7802 to 513e63a Compare January 17, 2025 11:08
@ryutamago ryutamago enabled auto-merge (rebase) January 17, 2025 11:09
@ryutamago ryutamago merged commit 3867a22 into main Jan 17, 2025
5 checks passed
@ryutamago ryutamago deleted the leounoki-jstz-257/introduce-new-account-type branch January 17, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants