-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jstz proto: introduce new account #758
Conversation
Codecov ReportAttention: Patch coverage is
Continue to review full report in Codecov by Sentry.
|
42a6381
to
6360e44
Compare
3a0196c
to
c7a8f38
Compare
6360e44
to
ab024ef
Compare
c7a8f38
to
3bbf375
Compare
0a2db5c
to
e8957be
Compare
To aid with review, it would be helpful to add the specific commands that execute your tests in the "Manual Testing" section. |
e8957be
to
f1945d2
Compare
LGTM overall. Good job. 🚀 |
40e4cf7
to
a1ac76e
Compare
a1ac76e
to
64d7802
Compare
64d7802
to
513e63a
Compare
Context
first step of migrarting to a new account
task link
in preparation for 255
Description
Added a new account context that handles address of both user and smart function. For a clearer api, we should use
SmartFunctionHash
for methods that's only intended for sf. This can be implemented after the migration to the new account type is completed.In the next step, the old account should be replaced with the new one.
Manually testing the PR
Unit tests are added.