Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jstzd): add quebec params #766

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

huancheng-trili
Copy link
Collaborator

Context

Part of JSTZ-273.
JSTZ-273

Description

Add a parameter file for protocol version quebec. This is basically the same as the current alpha version.

Manually testing the PR

Launched jstzd locally with a config file {"protocol":{"protocol":"quebec"}} and observed that jstzd could understand the protocol version and run normally.

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.52%. Comparing base (635c6ba) to head (98874b4).
Report is 1 commits behind head on main.

Files with missing lines Coverage Δ
crates/octez/src/async/protocol.rs 94.97% <100.00%> (+0.43%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 635c6ba...98874b4. Read the comment docs.

@huancheng-trili huancheng-trili marked this pull request as ready for review January 14, 2025 16:10
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-273-2 branch from b1b5678 to 773275d Compare January 15, 2025 11:10
Base automatically changed from huanchengchang-jstz-273-2 to main January 15, 2025 11:40
@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-273-3 branch from aac5af3 to ef6f2e9 Compare January 15, 2025 13:09
Copy link
Collaborator

@ryutamago ryutamago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@huancheng-trili huancheng-trili force-pushed the huanchengchang-jstz-273-3 branch from ef6f2e9 to 98874b4 Compare January 16, 2025 21:36
@huancheng-trili huancheng-trili enabled auto-merge (rebase) January 16, 2025 21:37
@huancheng-trili huancheng-trili merged commit 345123f into main Jan 16, 2025
3 checks passed
@huancheng-trili huancheng-trili deleted the huanchengchang-jstz-273-3 branch January 16, 2025 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants