-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jstz core: Introduce BinEncodable
trait for consistent serialization
#773
Closed
ryutamago
wants to merge
2
commits into
ryan-jstz-281/use-bincode-for-value-storage
from
refactor-value-trait
Closed
Jstz core: Introduce BinEncodable
trait for consistent serialization
#773
ryutamago
wants to merge
2
commits into
ryan-jstz-281/use-bincode-for-value-storage
from
refactor-value-trait
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcabter
force-pushed
the
ryan-jstz-281/use-bincode-for-value-storage
branch
from
January 16, 2025 16:48
6dc9b92
to
b13ddf3
Compare
zcabter
force-pushed
the
ryan-jstz-281/use-bincode-for-value-storage
branch
from
January 16, 2025 18:27
b13ddf3
to
2738895
Compare
ryutamago
changed the title
Encapsulate encode/decode
Jstz core: Introduce Jan 16, 2025
BinEncodable
trait for consistent serialization
ryutamago
force-pushed
the
refactor-value-trait
branch
3 times, most recently
from
January 16, 2025 21:31
ad5d8f2
to
1c68b7b
Compare
zcabter
reviewed
Jan 17, 2025
zcabter
reviewed
Jan 17, 2025
zcabter
reviewed
Jan 17, 2025
zcabter
reviewed
Jan 17, 2025
ryutamago
force-pushed
the
refactor-value-trait
branch
from
January 17, 2025 10:43
1c68b7b
to
53b96fc
Compare
zcabter
force-pushed
the
ryan-jstz-281/use-bincode-for-value-storage
branch
from
January 17, 2025 14:47
2738895
to
43d81da
Compare
closing this as it's cherry picked into #767 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The original Value design had the following issues:
while the standalone deserialize() used a different format
This PR ensures consistent serialization format through BinEncodable trait, removing potential for format mismatches. Additionally, it simplifies the storage/transaction APIs as the Value trait is bounded by the BinEncodable trait
related comment:
#767 (comment)
Task
Description
This PR introduces a dedicated BinEncodable trait to handle serialization consistently:
Value
traitManually testing the PR
Unit tests for encoding:
Deployed and ran sf manually.