Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client-lib): update client lib #774

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Conversation

zcabter
Copy link
Collaborator

@zcabter zcabter commented Jan 16, 2025

Context

This PR updates the jstz sdk to use the client lib. Technically, users don't need to use the client sdk but it has some convenience features that might be cherry-picked into the generated client lib.

Will review this in the next step as it is getting quite difficult to work across jstz and jstz-client repos with varying head branches.

Description

  • Updates jstz sdk to use published version jstz-client. Note that this is published to my personal scope for now until we move @jstz-dev to trilitech org
  • Updates example dashboard
  • The js_jstz build was initially failing because the dependency, undici-types was being pulled in with 2 none resolvable versions which was causingENOTCACHED issues. The violating dependency versions were being brought in by node dependency where v18 (the one client lib uses) and v20 (the one jstz package uses) used 2 unresolvable versions. To circumvent this, I bumped the node version on client lib to v20.

Manually testing the PR

# Jstzd should be running

npm install
cd examples/dashboard
npm run dev 

# Play around with the dashboard


@zcabter zcabter force-pushed the ryan-jstz-160-2/update-client-sdk branch from 8ddfd3e to 4eddddb Compare January 16, 2025 17:08
packages/sdk/package.json Outdated Show resolved Hide resolved
@zcabter zcabter force-pushed the ryan-jstz-160-1/flatten-client-api branch 2 times, most recently from 2d41acb to b40d0ef Compare January 21, 2025 09:49
Base automatically changed from ryan-jstz-160-1/flatten-client-api to main January 21, 2025 10:15
@zcabter zcabter force-pushed the ryan-jstz-160-2/update-client-sdk branch from 4eddddb to 27acf08 Compare January 21, 2025 17:27
@zcabter zcabter force-pushed the ryan-jstz-160-2/update-client-sdk branch from 27acf08 to 34372a1 Compare January 22, 2025 17:38
@zcabter zcabter requested a review from ryutamago January 22, 2025 17:47
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.34%. Comparing base (d8d8462) to head (aa1d8c7).
Report is 1 commits behind head on main.

Files with missing lines Coverage Δ
crates/jstz_proto/src/operation.rs 60.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d8462...aa1d8c7. Read the comment docs.

Copy link
Collaborator

@ryutamago ryutamago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general, lgtm🛳️
please update the docs later too!

@ryutamago ryutamago assigned zcabter and unassigned ryutamago Jan 23, 2025
@zcabter
Copy link
Collaborator Author

zcabter commented Jan 24, 2025

in general, lgtm🛳️ please update the docs later too!

Tracked: https://linear.app/tezos/issue/JSTZ-288/update-docs-for-client-lib

@zcabter zcabter enabled auto-merge (rebase) January 24, 2025 12:11
@zcabter zcabter merged commit b22aca4 into main Jan 24, 2025
3 checks passed
@zcabter zcabter deleted the ryan-jstz-160-2/update-client-sdk branch January 24, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants