-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client-lib): update client lib #774
Conversation
8ddfd3e
to
4eddddb
Compare
2d41acb
to
b40d0ef
Compare
4eddddb
to
27acf08
Compare
27acf08
to
34372a1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general, lgtm🛳️
please update the docs later too!
Tracked: https://linear.app/tezos/issue/JSTZ-288/update-docs-for-client-lib |
Context
This PR updates the jstz sdk to use the client lib. Technically, users don't need to use the client sdk but it has some convenience features that might be cherry-picked into the generated client lib.
Will review this in the next step as it is getting quite difficult to work across
jstz
andjstz-client
repos with varying head branches.Description
@jstz-dev
to trilitech orgundici-types
was being pulled in with 2 none resolvable versions which was causingENOTCACHED
issues. The violating dependency versions were being brought in bynode
dependency where v18 (the one client lib uses) and v20 (the one jstz package uses) used 2 unresolvable versions. To circumvent this, I bumped the node version on client lib to v20.Manually testing the PR