Jstz proto: fix kv value serialization #775
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Bug:
Running the example/counter.js sf fails on the second time, resulitng in derserialization error (Serde(AnyNotSupported))
Cause:
KvValue
currently relies on#[bincode(with_serde)]
for deserializing theserde_json::Value
. This forcese bincode to invokesserde_json
'sdeserialize
method. For example, in serde_json, theNumber
type is deserialized using deserialized_any method.However the deserializer, provided by bincode decoder, doesn't support deserializing "any" type, resulting in an error.
This PR fix this issue by manually implementing Decode/Encode method.
Task link
Description
Manually testing the PR
add unit tests for
KvValue
manually tested by deploying sf
counter.js
and runnig it twice.Before:
After: