forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom signets #12
Open
jtimon
wants to merge
31
commits into
master
Choose a base branch
from
jt_signet
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Custom signets #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtimon
force-pushed
the
jt_signet
branch
6 times, most recently
from
September 8, 2019 17:18
827cfac
to
9678146
Compare
3 tasks
...reads params from regular arguments Qt: Add a default purple and title for unkown chains
This also moves GetWitnessCommitmentIndex out of validation.cpp into CBlock, with 3 lines affected (GetWitnessCommitmentIndex(block) -> block.GetWitnessCommitmentIndex()).
The simple signature takes a sighash as argument and verifies a signature and pubkey against it. It is used in signet for verifying blocks, but can be used for practically anything.
Also adds a condition to test initialization code to not generate blocks for signet chains.
Running with -signet without any other parameters will use this network's parameters.
(except for the default seeds)
...which are not only valid by definition but are also a consensus rule for their own chain
ie custom signets are still covered with any other value for -chain Support signet networks within custom An alternative config file for a rebooted signet could be: chain=signet2 [signet2] con_signet_blocks=1 signet_blockscript=512103ad5e0edad18cb1f0fc0d28a3d4f1f3e445640337489abb10404f2d1e086be43051ae seednode=178.128.221.177 seednode=2a01:7c8:d005:390::5 seednode=ntv3mtqw5wt63red.onion:38333
signet chains, including the default can be just a concrete cases in custom chains For example: chain=signet [signet] con_signet_blocks=1 signet_blockscript=512103ad5e0edad18cb1f0fc0d28a3d4f1f3e445640337489abb10404f2d1e086be43051ae seednode=178.128.221.177 seednode=2a01:7c8:d005:390::5 seednode=ntv3mtqw5wt63red.onion:38333
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is bitcoin#16411 rebased on top of more things of mine.
It also has some commits at the end to further discuss how these things could be combined.
Dependencies: