Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml: Add gui directory to volumes of explorer docker #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bitstein
Copy link
Contributor

@bitstein bitstein commented Mar 5, 2018

This adds the gui directory the volumes of the explorer image so it doesn't need to be rebuilt during front-end development and other updates.

@jtimon
Copy link
Owner

jtimon commented Mar 13, 2018

Mhmm, this doesn't seem to work for me locally for me, it seems the following line is not working as expected after this change: https://github.com/jtimon/elements-explorer/blob/master/docker/explorer/Dockerfile#L17
No angular packages are being served. See https://github.com/jtimon/elements-explorer/blob/master/docker/explorer/package.json

@bitstein bitstein changed the title docker-compoose.yml: Add gui directory to volumes of explorer docker docker-compose.yml: Add gui directory to volumes of explorer docker Mar 13, 2018
@bitstein
Copy link
Contributor Author

I'm having the same issue now. There may have been something cached when I tested previously.

@jtimon jtimon force-pushed the master branch 2 times, most recently from 03ce99a to e110ed5 Compare August 2, 2018 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants