Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Addition: generalize EXTENDS for other prefix-groups (e.g., plugins) and add parameters for ipcluster #546

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

clearf
Copy link

@clearf clearf commented Aug 5, 2015

This commit:

  • Reorganizes config.py to generalize extends to other prefixes (to allow, e.g., plugins to extend each other)
    • Add tests to ensure that the use of EXTENDS behaves as expected for a plugin
  • Modified the template config to include examples of EXTENDS in a plugin
  • As an additional note, this PR does not pass all nosetests, but per (http://star.mit.edu/cluster/mlarchives/2700.html), neither do tests run on a clean develop or master branch.

@cancan101
Copy link

This should probably be broken up into two PRs.

@clearf
Copy link
Author

clearf commented Aug 5, 2015

OK, I'll split up and rebase. Good point.

@clearf
Copy link
Author

clearf commented Aug 5, 2015

@cancan101 OK, I took out the ipcluster changes, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants