matplotlib -> matplotlib-base in requirements #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aplymill7 this change is requested by conda-forge. It reduces the requirements by only requiring the base modules of matplotlib that don't contain qt. It should be ready to merge. Now that pyside is replacing qt, we should think about making a proper release and pushing it to conda-forge |
|
The changes look fine to me. Not sure what happened with Travis. It appears to have passed all the tests but coverage report failed. Not sure it you can get it to try again. |
|
Looks fine by me. Yeah not sure why it failed. Is it okay to merge even though this is the case? |
|
better to figure out why it is failing.....
…On Sat, Feb 15, 2020 at 11:44 AM aplymill7 ***@***.***> wrote:
Looks fine by me. Yeah not sure why it failed. Is it okay to merge even
though this is the case?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#138?email_source=notifications&email_token=ABAOWUIKKAO6DLCPRBFXMZ3RDALXFA5CNFSM4KVX2CS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3RMMQ#issuecomment-586618418>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAOWUKJ4LX4UHE5VW4NFNDRDALXFANCNFSM4KVX2CSQ>
.
--
Professor Simon Billinge
Columbia University
|
|
btw, some of our other packages have been failing. I think it may be a new
python release and travis is using the latest version, but possibly we are
not in our local envs. It is probably a good time to update everything
locally and try and track it down that way.
…On Sat, Feb 15, 2020 at 11:46 AM Simon Billinge ***@***.***> wrote:
better to figure out why it is failing.....
On Sat, Feb 15, 2020 at 11:44 AM aplymill7 ***@***.***>
wrote:
> Looks fine by me. Yeah not sure why it failed. Is it okay to merge even
> though this is the case?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#138?email_source=notifications&email_token=ABAOWUIKKAO6DLCPRBFXMZ3RDALXFA5CNFSM4KVX2CS2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3RMMQ#issuecomment-586618418>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABAOWUKJ4LX4UHE5VW4NFNDRDALXFANCNFSM4KVX2CSQ>
> .
>
--
Professor Simon Billinge
Columbia University
--
Professor Simon Billinge
Columbia University
|
|
closed by #188 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.