Allow noise gate to work as an expander #1224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamierpond
approved these changes
May 15, 2023
| @@ -49,8 +49,6 @@ void NoiseGate<SampleType>::setThreshold (SampleType newValue) | |||
| template <typename SampleType> | |||
| void NoiseGate<SampleType>::setRatio (SampleType newRatio) | |||
| { | |||
| jassert (newRatio >= static_cast<SampleType> (1.0)); | |||
There was a problem hiding this comment.
Possibly worthwhile checking for negative ratios?
This fixes a warning when running xcodebuild directly
This allows real-time threads to join an audio workgroup on Apple platforms.
…copy step This fixes a build failure on MacOS Sonoma when the copy plugin step is enabled.
Only include context observer block when workgroup types available.
This also adds missing KHRONOS_APIENTRY qualifications to the debug callback type, which fixes potential crashes when running debug Win32 builds.
The new class hold a list of ChildProcesses and periodically checks their return value until they report termination. On Linux this check is necessary to avoid leaving zombie processes behind.
…eave zombies This change also avoids the AudioPluginHost leaving zombie child processes behind.
…ponent is modal The change does not affect plugin windows, which are created by the host.
The old API only allowed cancelling property "get" inquiries and subscription updates. However, there are use-cases for cancelling other requests too. e.g. switching between views in a JUCE app might mean that it's no longer necessary to subscribe to a particular property. Cancelling subscriptions ends up being quite involved. Different handling is needed depending on whether the subscription is cancelled before or after the responder replies to the initial request. In addition, the responder may ask the initiator to retry a subscription begin request.
We avoid modifying window controls in modal situations if possible. Doing as much as [window setStyleMask: [window styleMask]]; for a PopupMenu window will make it invisible on MacOS when the plugin is hosted in an external subprocess. This fixes a regression caused by fb14118.
…sinc interpolator Users reported this caused missed deadlines and performance penalties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The noise gate documentation says that if the ratio is low enough it can be used as an expander, however, there is an assertion forcing the ratio to be above or equal to 1.0. This stops the gate being usable as an expander. I have simply removed this assertion and edited the documentation.