Add fallback SIMD implementation #1342
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used on platforms that don't have native SIMD support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on platforms that don't have an implementation of
SIMDNativeOps,SIMDRegisteris not available.This PR makes functionality gracefully degrade by adding a fallback implementation of
SIMDNativeOpsthat simply calls the fallback functions that already exist inSIMDFallbackOps.On platforms that already support SIMD, nothing changes, but other platforms will now have implementations of
SIMDRegisterthat use the fallback functions, so software that usesSIMDRegisterwill automatically support more platforms without any additional effort.All unit tests pass on
x86_64,aarch64, andppc64le.