Changed how HTTP headers are ended on Linux #1352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminya
reviewed
Mar 29, 2024
| @@ -525,7 +525,14 @@ class WebInputStream::Pimpl | |||
| if (userHeaders.isNotEmpty()) | |||
| header << "\r\n" << userHeaders; | |||
|
|
|||
| header << "\r\n\r\n"; | |||
| if(header.toString().endsWith("\r\n")) | |||
There was a problem hiding this comment.
I am sure there's a better to detect \r\n than creating a string copy here.
There was a problem hiding this comment.
I have added another commit which uses a reference to a variable.
There was a problem hiding this comment.
What I meant was the toString call, which I think creates a string copy. It should not matter much as headers should be small.
The actual string literals were fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fixing the error reported at https://forum.juce.com/t/url-header-suffix-on-linux/59985/2
Essentially the HTTP header section should end with "/r/n/r/n". The previous code was not taking into account that there might already be some of the suffix present before applying it.