[bugfix] Fixed to properly convert multibyte text to juce::String. #1393
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes an issue where the implementation of the
juce::String::fromUTF8
function incorrectly handles multi-byte character strings.Details
The current implementation may incorrectly treat parts of multi-byte character strings as invalid characters.
For example, consider the following code:
As you can see, the multi-byte characters in the file path are not properly handled, leading to incorrect encoding and data corruption.
With this fix, multi-byte character strings are properly interpreted, and the entire string is correctly decoded.
After fix
With this fix applied, the execution result of the above code will change, and the conversion process from multi-byte character strings (including Japanese characters) to juce::String will work correctly.
Related Files
juce_String.cpp
- Modified the implementation of thefromUTF8
function.