Figbug/variantimprovements #1474
Open
+273
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just want to vouch that I'd use this in some of my projects almost immediately if it were merged. Thanks for the great work @FigBug .. |
FigBug
force-pushed
the
figbug/variantimprovements
branch
from
f7d86f1 to
09d8ea8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently trying to remove as many dependancies as possible from my app. Currently thinking it would be nice to use JUCE's json parsing rather than a 3rd party library like
nlohmann. However,juce::varlacks some functions that would make handling the parsed json a lot less verbose.juce::var has getProperty and hasProperty, but no getProperties.
Iterating over properties is a pain. You need to get the dynamic object from the var, from the dynamic object you need to get the NamedValueSet, and then you can iterate that. Adding begin/end to var, would make things a lot easier, especially if they could do both arrays and objects.
Finally, JSONUtils supports using json pointers for setting values, but not getting values.
I have created potential implementations