Enable Jack Audio on macOS and Windows #1489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, seems you copied this work under your own commit @chromadevlabs I guess then my job here is done. |
|
@dromer I apologize for this, It was entirely my mistake, and I only realized I forgot to add you as a co-author after it was already published. |
|
@chromadevlabs ok, thank you for explaining. Considering the PR history I thought this was considered the general practice of the team. The changes are quite minor, so I'm mostly just glad that after ~15 years this is finally resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This finally enables Jack Audio for all supported platforms.
It closes #1176 and resolves numerous forum topics.